Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76371136 |
joevilches
force-pushed
the
export-D76371136
branch
from
64c85f9 to
7321c7d
Compare
Summary: Pull Request resolved: facebook#51940 We are seeing some reports of badf00d fads (stalls), meaning we are likely doing too much work here. `accessibilityElements` gets called a lot, and is often cached so lets add that in. Changelog: [Internal] Reviewed By: jorge-cab Differential Revision: D76371136
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76371136 |
joevilches
force-pushed
the
export-D76371136
branch
from
7321c7d to
a34a300
Compare
Contributor
|
This pull request has been merged in 0e1a94a. |
Collaborator
|
This pull request was successfully merged by @joevilches in 0e1a94a When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
We are seeing some reports of badf00d fads (stalls), meaning we are likely doing too much work here.
accessibilityElementsgets called a lot, and is often cached so lets add that in.Changelog: [Internal]
Differential Revision: D76371136